support for guarded transactions for v1 relayed tx #251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| "name": "@multiversx/sdk-core", | ||
| "version": "12.0.1", | ||
| "version": "12.0.1-alpha.1", |
Contributor
There was a problem hiding this comment.
Normally, 12.0.1-alpha.x < 12.0.1, but in this case we can indeed use -alpha.1, because there's no 12.0.1 published.
|
|
||
| describe("test relayed v1 transaction builder", function () { | ||
| let alice: TestWallet, bob: TestWallet; | ||
| let alice: TestWallet, bob: TestWallet, eve: TestWallet; |
Contributor
There was a problem hiding this comment.
Usually, eve has a "bad name" (as in eavesdropping) - but here it seems to be the guardian. Perhaps we should find a better name?
src/relayedTransactionV1Builder.ts
Outdated
| relayerAddress: IAddress | undefined; | ||
| relayerNonce: INonce | undefined; | ||
| netConfig: INetworkConfig | undefined; | ||
| relayTransactionOptions: TransactionOptions | undefined; |
Contributor
There was a problem hiding this comment.
Below I see the prefix relayed. Which one should be here?
| receiver: Address.fromBech32("erd1qqqqqqqqqqqqqqqpqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqzllls8a5w6u"), | ||
| gasLimit: 60000000, | ||
| chainID: networkConfig.ChainID, | ||
| data: new TransactionPayload("getContractConfig"), |
Contributor
There was a problem hiding this comment.
Perhaps use a simple TX instead? Here - the receiver is a contract and the data is the name of a contract query function, is this mandatory for the test?
bogdan-rosianu
approved these changes
Feb 1, 2023
andreibancioiu
approved these changes
Feb 1, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.