Synchronize network providers #557

danielailie · 2025-01-15T11:57:16Z

No description provided.

andreibancioiu · 2025-01-20T12:00:40Z

src/abi/smartContract.local.net.spec.ts

    });

-    it("counter: should deploy, then simulate transactions using SmartContractTransactionsFactory", async function () {
+    it.only("counter: should deploy, then simulate transactions using SmartContractTransactionsFactory", async function () {


Drop only.

andreibancioiu · 2025-01-20T12:02:32Z

src/networkProviders/apiNetworkProvider.dev.net.spec.ts

+import { TransactionStatus } from "../transactionStatus";
+import { ApiNetworkProvider } from "./apiNetworkProvider";
+
+describe.only("ApiNetworkProvider Tests", function () {


Should drop only.

andreibancioiu · 2025-01-20T12:03:58Z

src/transaction.local.net.spec.ts


    it("should simulate transactions", async function () {
        this.timeout(20000);
+        const JSONbig = require("json-bigint")({ constructorAction: "ignore" });


Maybe have the import and a wrapper over jsonBig.parse() within test utils?

andreibancioiu · 2025-01-20T12:04:38Z

src/transactionOnNetwork.ts

    }

+    static fromSimulateResponse(originalTx: Transaction, response: any): TransactionOnNetwork {
+        console.log(response);


Logging artifact.

andreibancioiu · 2025-01-20T12:06:28Z

src/testutils/mockNetworkProvider.ts

        throw new ErrMock("Transaction not found");
    }

-    async getTransactionStatus(txHash: string): Promise<TransactionStatus> {


Completely removed? Maybe we should still keep it & add it in the specs?

https://github.com/multiversx/mx-sdk-specs/blob/main/network-providers/interface.md

andreibancioiu · 2025-01-20T12:07:09Z

src/networkProviders/proxyNetworkProvider.dev.net.spec.ts

+import { TransactionStatus } from "../transactionStatus";
+import { ProxyNetworkProvider } from "./proxyNetworkProvider";
+
+describe.only("ProxyNetworkProvider Tests", function () {


only should be removed.

andreibancioiu · 2025-01-20T12:09:30Z

src/networkProviders/resources.ts

+    }
+
+    static fromHttpResponse(payload: any): AccountStorage {
+        let result = new AccountStorage();


Can also be const.

andreibancioiu · 2025-01-20T12:12:49Z

src/networkProviders/interface.ts

+     * Fetches a block by nonce or by hash.
     */
-    getNetworkStakeStatistics(): Promise<NetworkStake>;
+    getBlock(blockArgs: GetBlockArguments): Promise<BlockOnNetwork>;


I think this is removed from the interface in sdk-py, and implemented differently in API provider and proxy provider. How should we proceed?

andreibancioiu · 2025-01-20T12:13:53Z

src/networkProviders/resources.ts

+    }
+}
+
+export class GetBlockArguments {


I think this is removed from sdk-py. Does it make sense to drop it here, as well, and also in specs?

andreibancioiu · 2025-01-20T12:14:58Z

src/networkProviders/networkConfig.ts

     * The gas required by the Network to process a byte of the transaction data.
     */
-    public GasPerDataByte: number;
+    public GasPerDataByte: bigint;


These use a different capitalization. Maybe rename them for consistency (even if that leads to a small breaking change)?

popenta · 2025-01-20T14:21:15Z

src/networkProviders/apiNetworkProvider.ts

+        const response = await this.doPostGeneric(url, transaction);
+        const data = response["data"] ?? {};
+        return TransactionOnNetwork.fromSimulateResponse(transaction, data["result"] ?? {});
+    }


add empty line

popenta · 2025-01-20T14:23:07Z

src/networkProviders/apiNetworkProvider.ts

+        });
+        return await awaiter.awaitOnCondition(transactionHash, condition);
    }
+    async awaitTransactionCompleted(transactionHash: string, options?: AwaitingOptions): Promise<TransactionOnNetwork> {


add empty line

popenta · 2025-01-20T14:25:44Z

src/networkProviders/apiNetworkProvider.ts

+    async getGuardianData(address: Address): Promise<GuardianData> {
+        return await this.backingProxyNetworkProvider.getGuardianData(address);
+    }


this is not in the specs, right?

popenta · 2025-01-20T14:28:25Z

src/networkProviders/apiNetworkProvider.ts

+    async getMexPairs(pagination?: IPagination): Promise<PairOnNetwork[]> {
+        let url = `mex/pairs`;
+        if (pagination) {
+            url = `${url}?from=${pagination.from}&size=${pagination.size}`;
+        }
+
+        const response: any[] = await this.doGetGeneric(url);
+
+        return response.map((item) => PairOnNetwork.fromApiHttpResponse(item));
+    }


this is very old and unused I'd say :)

popenta · 2025-01-20T14:32:02Z

src/abi/smartContract.local.net.spec.ts

        const deployTxHash = await provider.sendTransaction(deployTransaction);
        const callTxHash = await provider.sendTransaction(smartContractCallTransaction);
-
+        console.log({ deployTxHash, callTxHash });


this can be removed

popenta · 2025-01-21T09:28:21Z

src/networkProviders/resources.ts

+export class BlockCoordinates {
+    nonce: bigint = 0n;
+    hash: string = "";
+    rootHash?: string;


why is this optional?

popenta · 2025-01-21T09:28:40Z

src/networkProviders/resources.ts

+    address: Address = Address.empty();
+    key: string = "";
+    value: string = "";
+    constructor(init?: Partial<AccountStorageEntry>) {


add empty line

popenta · 2025-01-21T09:29:18Z

src/networkProviders/resources.ts

+    patienceInMilliseconds: number = DEFAULT_ACCOUNT_AWAITING_PATIENCE_IN_MILLISECONDS;
+}
+
+export class TransactionCostEstimationResponse {


this is called TransactionCostResponse in the specs.

popenta · 2025-01-21T09:29:52Z

src/networkProviders/resources.ts

+    token: Token = new Token({ identifier: "" });
+    amount: bigint = 0n;
+    block_coordinates?: BlockCoordinates;
+    constructor(init?: Partial<TokenAmountOnNetwork>) {


add empty line.

popenta · 2025-01-21T09:30:31Z

src/testutils/utils.ts

+export function importJsonBig(value: string): string {
+    return Buffer.from(value, "base64").toString("hex");
+}
+export const stringifyBigIntJSON = (jsonString: any): any => {


add empty line

danielailie added 3 commits January 15, 2025 13:21

update network providers to follow specs

b319e26

Remove unused methods

93db149

Remove methods that are not in specs

339e723

danielailie self-assigned this Jan 15, 2025

danielailie added 9 commits January 15, 2025 16:29

Add proxy provider tests

761069e

Add proxy provider tests

86aed28

Add api provider tests

135012d

Fix failing tests

a9448f0

Fix integration test and skip proxy test that returns timeout

8855cb4

Update network config to follow specs

e3c1738

Update Network status

abe8456

Fix getTokenAccount

5453522

Add logging

04d412d

andreibancioiu reviewed Jan 20, 2025

View reviewed changes

danielailie added 11 commits January 20, 2025 14:18

Remove only for tests

80d367e

Fix proxy account mapping

88c9056

Update to const where posible

23ae906

Fix proxy test

505262b

Add transaction status method

9e14ee4

remove getBlockArguments and add back transactionStatus

5e94b19

Add wrapper over JsonBigInt

a1d1834

Remove only

2500ca9

Update naming to keep naming convention

8438aa9

Fix tests

378e636

Fix integration tests

7e5f1aa

andreibancioiu previously approved these changes Jan 21, 2025

View reviewed changes

popenta reviewed Jan 21, 2025

View reviewed changes

Code review follow up

93600bb

danielailie dismissed andreibancioiu’s stale review via 93600bb January 21, 2025 10:11

Fix compiling errors

d2847bc

add back transaction Status tests

bf102a7

popenta approved these changes Jan 21, 2025

View reviewed changes

andreibancioiu approved these changes Jan 21, 2025

View reviewed changes

danielailie merged commit 628d09b into feat/next Jan 21, 2025
4 checks passed

danielailie deleted the TOOL-411-synchronize-network-providers branch January 21, 2025 11:33

Synchronize network providers #557

Synchronize network providers #557

Uh oh!

Conversation

danielailie commented Jan 15, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

andreibancioiu Jan 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

andreibancioiu Jan 20, 2025 •

edited

Loading