Remove TransactionHash and hash and update to use TransactionComputer.computeTransactionHash #566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….computeTransactionHash
src/abi/smartContract.spec.ts
Outdated
Comment on lines
194
to
195
| const computer = new TransactionComputer(); | ||
| const hashString = computer.computeTransactionHash(deployTransaction); |
Contributor
There was a problem hiding this comment.
Needed? We have a hash above. Sorry if mistaken.
src/abi/interaction.spec.ts
Outdated
| transaction.getHash().toString(), | ||
| "3579ad09099feb9755c860ddd225251170806d833342e912fccdfe2ed5c3a364", | ||
| ); | ||
| const computer = new TransactionComputer(); |
Contributor
There was a problem hiding this comment.
Maybe can hold result of await provider.sendTransaction(transaction); and don't use this computer? (serves as a more real-world example, I think).
popenta
previously approved these changes
Jan 29, 2025
src/abi/interaction.spec.ts
Outdated
| "3579ad09099feb9755c860ddd225251170806d833342e912fccdfe2ed5c3a364", | ||
| ); | ||
| const computer = new TransactionComputer(); | ||
| let hashString = computer.computeTransactionHash(transaction); |
Contributor
There was a problem hiding this comment.
could've simply been called hash.
| const hash = createTransactionHasher(TRANSACTION_HASH_LENGTH).update(buffer).digest("hex"); | ||
|
|
||
| return Buffer.from(hash, "hex"); | ||
| return Buffer.from(hash, "hex").toString("hex"); |
Contributor
There was a problem hiding this comment.
I think hash is already a hex string so there's no need to convert it again. Right?
andreibancioiu
approved these changes
Jan 29, 2025
popenta
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.