Add verifyMessage and verifyTransaction on account #572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreibancioiu
previously approved these changes
Feb 3, 2025
| * @returns true if the signature is valid, false otherwise | ||
| */ | ||
| verify(data: Buffer | Uint8Array, signature: Buffer | Uint8Array): boolean { | ||
| async verify(data: Buffer | Uint8Array, signature: Buffer | Uint8Array): Promise<boolean> { |
Contributor
There was a problem hiding this comment.
Minor breaking change, we should document (not forget about) it.
| } | ||
|
|
||
| verifyMessageSignature(message: Message): boolean { | ||
| async verifyMessageSignature(message: Message, account: IAccount): Promise<boolean> { |
Contributor
There was a problem hiding this comment.
In account, we have verifyTransaction and verifyMessage. Here, we also have the suffix signature. Keep it or drop it? (either way should be fine, but we must also reflect this in the specs).
Contributor
There was a problem hiding this comment.
I kind of like having signature in the name, but if we decide to drop it, it's fine
| const ciphertext = Buffer.from(data.ciphertext, 'hex'); | ||
| const edhPubKey = Buffer.from(data.identities.ephemeralPubKey, 'hex'); | ||
| const originatorPubKeyBuffer = Buffer.from(data.identities.originatorPubKey, 'hex'); | ||
| static async decrypt(data: X25519EncryptedData, decryptorSecretKey: UserSecretKey): Promise<Buffer> { |
Contributor
There was a problem hiding this comment.
Minor breaking change. Let's mention it in the PR description, as well, so that we don't forget to document it in the release notes.
mradian1
previously approved these changes
Feb 3, 2025
danielailie
dismissed stale reviews from mradian1 and andreibancioiu
via
4f315d6
andreibancioiu
approved these changes
Feb 4, 2025
mradian1
approved these changes
Feb 4, 2025
popenta
approved these changes
Feb 4, 2025
danielailie
deleted the
TOOL-460-add-verify-message-and-verify-signature
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.