Update token ticker validation rules #573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popenta
reviewed
Feb 13, 2025
package.json
Outdated
| "bip39": "3.1.0" | ||
| } | ||
| } | ||
| } |
src/tokens.spec.ts
Outdated
| identifier = tokenComputer.extractIdentifierFromExtendedIdentifier(fungibleTokenIdentifier); | ||
| assert.equal(identifier, "FNG-123456"); | ||
|
|
||
| const numericTokenTicker = "2024-45a190"; |
Contributor
There was a problem hiding this comment.
can we double check if lowercase ticker is accepted on the network?
Contributor
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
From here I understand that we can not have lowercase
https://github.com/multiversx/mx-chain-go/blob/master/vm/systemSmartContracts/esdt.go#L721
andreibancioiu
changed the title
src/tokens.spec.ts
Outdated
| identifier = tokenComputer.extractIdentifierFromExtendedIdentifier(fungibleTokenIdentifier); | ||
| assert.equal(identifier, "FNG-123456"); | ||
|
|
||
| const numericTokenTicker = "2024-45a190"; |
Contributor
There was a problem hiding this comment.
Maybe use a more artificial example (not the token from mainnet).
src/tokens.spec.ts
Outdated
| identifier = tokenComputer.extractIdentifierFromExtendedIdentifier(fungibleTokenIdentifier); | ||
| assert.equal(identifier, "FNG-123456"); | ||
|
|
||
| const numericTokenTicker = "2024-45a190"; |
Contributor
There was a problem hiding this comment.
andreibancioiu
approved these changes
Feb 13, 2025
popenta
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.