From c204cbecdbb42f69d506b5f7aa073b9fa124715d Mon Sep 17 00:00:00 2001 From: Lior Sion Date: Sun, 27 Feb 2011 19:22:12 +0200 Subject: [PATCH 1/2] changed size() to length for jquery 1.5+ on ff --- jquery.facebook.multifriend.select.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/jquery.facebook.multifriend.select.js b/jquery.facebook.multifriend.select.js index 2ff0643..72679d0 100644 --- a/jquery.facebook.multifriend.select.js +++ b/jquery.facebook.multifriend.select.js @@ -149,7 +149,7 @@ // already been selected, if so, just return if(!$(this).hasClass("selected") && maxSelectedEnabled() && - $(".jfmfs-friend.selected").size() >= settings.max_selected && + $(".jfmfs-friend.selected").length >= settings.max_selected && settings.max_selected != 1) { return; } @@ -176,7 +176,7 @@ for(var i=start; i<=end; i++) { var aFriend = $( all_friends[i] ); if(!aFriend.hasClass("hide-non-selected") && !aFriend.hasClass("hide-filtered")) { - if( maxSelectedEnabled() && $(".jfmfs-friend.selected").size() < settings.max_selected ) { + if( maxSelectedEnabled() && $(".jfmfs-friend.selected").length < settings.max_selected ) { $( all_friends[i] ).addClass("selected"); } } @@ -313,7 +313,7 @@ }; var selectedCount = function() { - return $(".jfmfs-friend.selected").size(); + return $(".jfmfs-friend.selected").length; }; var maxSelectedEnabled = function () { From bfd1b6d8d076b6a477ae358a98f76d5fb30a87a0 Mon Sep 17 00:00:00 2001 From: Lior Sion Date: Sun, 27 Mar 2011 11:58:34 +0200 Subject: [PATCH 2/2] some minor ui fixes --- jquery.facebook.multifriend.select.css | 3 ++- jquery.facebook.multifriend.select.min.js | 6 +++--- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/jquery.facebook.multifriend.select.css b/jquery.facebook.multifriend.select.css index 1042f89..87b4205 100644 --- a/jquery.facebook.multifriend.select.css +++ b/jquery.facebook.multifriend.select.css @@ -69,7 +69,8 @@ limitations under the License. #jfmfs-friend-selector { width:725px; - height:376px; + height:376px; + overflow-y:hidden; } #jfmfs-inner-header { diff --git a/jquery.facebook.multifriend.select.min.js b/jquery.facebook.multifriend.select.min.js index 7311630..5bbdb53 100644 --- a/jquery.facebook.multifriend.select.min.js +++ b/jquery.facebook.multifriend.select.min.js @@ -2,10 +2,10 @@ p;f++)h[d[f]]="";return h};b.html("
"+c.labels.filter_title+" "+c.labels.all+" "+c.labels.selected+" (0)"+(c.max_selected>0?"
": "")+"
");var q=a("#jfmfs-friend-container"),x=a("#jfmfs-friend-selector"),F=w(c.pre_selected_friends),G=w(c.exclude_friends),i;FB.api("/me/friends?fields="+c.friend_fields,function(d){d=d.data.sort(c.sorter);var h=[],f="";a.each(d,function(p,e){if(!(e.id in G)){f=e.id in F?"selected":"";h.push("
"+e.name+"
")}});q.append(h.join(""));g=a(".jfmfs-friend", b);g.bind("inview",function(){a(this).attr("src")===undefined&&a("img",a(this)).attr("src","//graph.facebook.com/"+this.id+"/picture");a(this).unbind("inview")});H()});this.getSelectedIds=function(){var d=[];a.each(b.find(".jfmfs-friend.selected"),function(h,f){d.push(a(f).attr("id"))});return d};this.getSelectedIdsAndNames=function(){var d=[];a.each(b.find(".jfmfs-friend.selected"),function(h,f){d.push({id:a(f).attr("id"),name:a(f).find(".friend-name").text()})});return d};this.clearSelected=function(){i.removeClass("selected")}; -var H=function(){i=a(".jfmfs-friend",b);r=i.first().offset().top;for(var d=0,h=i.length;d0&&a(".jfmfs-friend.selected").size()>=c.max_selected&&c.max_selected!=1)){c.max_selected==1&&b.find(".selected").removeClass("selected");a(this).toggleClass("selected");a(this).removeClass("hover");if(a(this).hasClass("selected"))if(u){if(e.shiftKey){var n= -a(this).index(),s=u.index();e=Math.max(n,s);for(n=Math.min(n,s);n<=e;n++){s=a(i[n]);!s.hasClass("hide-non-selected")&&!s.hasClass("hide-filtered")&&c.max_selected>0&&a(".jfmfs-friend.selected").size()0&&A();b.trigger("jfmfs.selection.changed",[m.getSelectedIdsAndNames()])}});a("#jfmfs-filter-selected").click(function(e){e.preventDefault();i.not(".selected").addClass("hide-non-selected");a(".filter-link").removeClass("selected"); +var H=function(){i=a(".jfmfs-friend",b);r=i.first().offset().top;for(var d=0,h=i.length;d0&&a(".jfmfs-friend.selected").length>=c.max_selected&&c.max_selected!=1)){c.max_selected==1&&b.find(".selected").removeClass("selected");a(this).toggleClass("selected");a(this).removeClass("hover");if(a(this).hasClass("selected"))if(u){if(e.shiftKey){var n= +a(this).index(),s=u.index();e=Math.max(n,s);for(n=Math.min(n,s);n<=e;n++){s=a(i[n]);!s.hasClass("hide-non-selected")&&!s.hasClass("hide-filtered")&&c.max_selected>0&&a(".jfmfs-friend.selected").length0&&A();b.trigger("jfmfs.selection.changed",[m.getSelectedIdsAndNames()])}});a("#jfmfs-filter-selected").click(function(e){e.preventDefault();i.not(".selected").addClass("hide-non-selected");a(".filter-link").removeClass("selected"); a(this).addClass("selected")});a("#jfmfs-filter-all").click(function(e){e.preventDefault();i.removeClass("hide-non-selected");a(".filter-link").removeClass("selected");a(this).addClass("selected")});b.find(".jfmfs-friend:not(.selected)").live("hover",function(e){e.type=="mouseover"&&a(this).addClass("hover");e.type=="mouseout"&&a(this).removeClass("hover")});b.find("#jfmfs-friend-filter-text").keyup(function(){var e=a(this).val();clearTimeout(o);o=setTimeout(function(){if(e=="")i.removeClass("hide-filtered"); else{x.find(".friend-name:not(:Contains("+e+"))").parent().addClass("hide-filtered");x.find(".friend-name:Contains("+e+")").parent().removeClass("hide-filtered")}f()},400)}).focus(function(){a.trim(a(this).val())=="Start typing a name"&&a(this).val("")}).blur(function(){a.trim(a(this).val())==""&&a(this).val("Start typing a name")});b.find(".jfmfs-button").hover(function(){a(this).addClass("jfmfs-button-hover")},function(){a(this).removeClass("jfmfs-button-hover")});var f=function(){var e=q.innerHeight(), -n=q.scrollTop(),s=q.offset().top,z,B=0,C=false,D=a(".jfmfs-friend:not(.hide-filtered )");a.each(D,function(I,y){B++;if(y!==null){y=a(D[I]);z=r+k*Math.ceil(B/v)-n-s;if(z+k>=-10&&z-k=-10&&z-k=0}})(jQuery); $.debounce===undefined&&function(a,t){var j=a.jQuery||a.Cowboy||(a.Cowboy={}),l;j.throttle=l=function(b,m,g,o){function v(){function c(){r=+new Date;g.apply(w,x)}function u(){k=t}var w=this,q=+new Date-r,x=arguments;o&&!k&&c();k&&clearTimeout(k);if(o===t&&q>b)c();else if(m!==true)k=setTimeout(o?u:c,o===t?b-q:b)}var k,r=0;if(typeof m!=="boolean"){o=g;g=m;m=t}if(j.guid)v.guid=g.guid=g.guid||j.guid++;return v};j.debounce=function(b,m,g){return g===t?l(b,m,false):l(b,g,m!==false)}}(this);