Fix error handling pattern in *.cmd #42

Merged
merged 1 commit into from Feb 8, 2017

Projects

None yet

2 participants

@hacst
Member
hacst commented Feb 8, 2017

Replace "if errorlevel 1 exit /b errorlevel" with
"if errorlevel 1 exit /b %ERRORLEVEL%". The latter
properly transports the errorlevel to outside callers
like powershell while the latter only seems to
work when the script is called from cmd.exe

@hacst hacst requested a review from mkrautz Feb 8, 2017
@mkrautz

I know it's a small thing, but why not %errorlevel%?

@hacst
Member
hacst commented Feb 8, 2017

Because that way it's easier to differentiate from our use of errorlevel.

@hacst hacst Fix error handling pattern in *.cmd
Replace "if errorlevel 1 exit /b errorlevel" with
"if errorlevel 1 exit /b %errorlevel%". The latter
properly transports the errorlevel to outside callers
like powershell while the latter only seems to
work when the script is called from cmd.exe
e944a90
@mkrautz mkrautz merged commit 1d06b07 into mumble-voip:master Feb 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment