Please sign in to comment.
Don't expose SSL secrets over Ice/D-Bus.
I think there's a good excuse for this: we don't expose a user's password hash over Ice, which is actually a pain in the backside for migrating servers via Ice. So in the interests of consistency, I think it's probably better to not expose the SSL private key or it's passphrase over Ice either, particularly since SSL keys are a bit of a "cat out the bag" thing. Note that at present, the SSL passphrase isn't exposed via meta either - the "key" field of meta.GetDefaultConf() contains a plaintext copy of the key, but I left the check in anyway in case we change that for any reason. When the user specifically requests things that ought to be secret over Ice, we raise an exception rather than have it silently fail, to hopefully reduce the amount of head-scratching some poor script writer has to do. Finally, more or less do the same thing over D-Bus.
- Loading branch information...
Showing with 21 additions and 3 deletions.