Skip to content
Permalink
Browse files

Merge PR #3188: Overlay_win: properly terminate our overlay helper pr…

…ocesses.
  • Loading branch information...
mkrautz committed Jul 20, 2017
2 parents 346702f + 3ea9f08 commit 14ac2b362013e06fcb7ed86dac9eea210c9c1987
Showing with 12 additions and 0 deletions.
  1. +12 −0 src/mumble/Overlay_win.cpp
@@ -133,6 +133,18 @@ OverlayPrivateWin::~OverlayPrivateWin() {
qFatal("OverlayPrivateWin: unable to close Mumble process handle.");
return;
}

// Remove all signals, so they don't
// interfere with our calls to waitForFinished
// below.
m_helper_process->disconnect();
m_helper64_process->disconnect();

m_helper_process->terminate();
m_helper64_process->terminate();

m_helper_process->waitForFinished();
m_helper64_process->waitForFinished();
}

void OverlayPrivateWin::startHelper(QProcess *helper) {

0 comments on commit 14ac2b3

Please sign in to comment.
You can’t perform that action at this time.