Please sign in to comment.
MainWindow: only allow layout to be changed via settings.
This simplifies our handling of our UI layout setting in MainWindow. Previously, we had slots that detected visibility and position changes for dock elements. And if any of them fired, we would revert back to the 'custom' layout. However, changing the layout behind the user's back meant we had to keep track of the original layout setting when we performed a re-layout of the MainWindow, such as when we apply new settings from the ConfigDialog. In Qt 5 (we think!), things changed, and the slots are called more frequently. Currently, that means that Mumble *always* resets to the 'custom' layout when applying settings. That's no good. This commit removes the slots that listen for layout and visibility changes for dock elements. It also removes MainWindow's 'dock widget' context menu when not in the 'custom' layout. The result is that you are now locked into the layout that you choose in the ConfigDialog. We already have code in Mumble that I wrote a while back that disables dragging of dock elements when you are not in the 'custom' layout. This is a natural extension of that: you can no longer modify the layout of the UI unless you choose 'custom'. Fixes #2003
- Loading branch information...
Showing with 11 additions and 27 deletions.