Please sign in to comment.
Fix #1637 application crashes on Mumble exit
* When unloading the overlay DLL freeD3D9Hook was called *after* unloading the DLL. This is incorrect. ** For applications that actually use D3D and we inject into, the DLL is never unloaded because we hold a refernce to it ourselves. So in this case, the problematic code is never executed. ** When not actually injecting, the DLL will be unloaded, and then the function freeD3D9Hook is called which is from that DLL. ** As we’re executing code in undefined space which previously held the function, this may or may not crash. * Remove the freeD3D9Hook function ** The function freeD3D9Hook just resets some fields to NULL and a flag to false. As the DLL is unloaded anyway, these are never used again. Hence, we can just remove it altogether (rather than just calling it before unloading).
- Loading branch information...
Showing with 0 additions and 23 deletions.