Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Suppress warnings in 3rd party codec builds
This patch disables all warnings in celt and opus builds.
They were very noise and drowned out the warnings in our
code to the point where no one even bothered looking at them.
As we don't inspect those warnings and won't attempt to fix
them anytime soon they are not useful to us.

Added third-party-warnings qmake CONFIG option to optionally
re-enable warnings for those (and in the future other) 3rd
part builds.
  • Loading branch information
hacst committed Jul 4, 2015
1 parent 46cb8a3 commit fac930b
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 4 deletions.
9 changes: 7 additions & 2 deletions 3rdparty/celt-0.11.0-build/celt-0.11.0-build.pro
Expand Up @@ -13,8 +13,6 @@ VERSION=$$replace(VERSION,celt-,)
TEMPLATE = lib
CONFIG -= qt
CONFIG += debug_and_release
CONFIG -= warn_on
CONFIG += warn_off
CONFIG += no_include_pwd
VPATH = ../$$SOURCEDIR/libcelt
TARGET = celt0
Expand All @@ -27,6 +25,13 @@ CONFIG(static) {
CONFIG += shared
}

!CONFIG(third-party-warnings) {
# We ignore warnings in third party builds. We won't actually look
# at them and they clutter out our warnings.
CONFIG -= warn_on
CONFIG += warn_off
}

QMAKE_CFLAGS -= -fPIE -pie

win32 {
Expand Down
7 changes: 7 additions & 0 deletions 3rdparty/celt-0.7.0-build/celt-0.7.0-build.pro
Expand Up @@ -32,6 +32,13 @@ CONFIG(sbcelt) {
}
}

!CONFIG(third-party-warnings) {
# We ignore warnings in third party builds. We won't actually look
# at them and they clutter out our warnings.
CONFIG -= warn_on
CONFIG += warn_off
}

QMAKE_CFLAGS -= -fPIE -pie

win32 {
Expand Down
9 changes: 7 additions & 2 deletions 3rdparty/opus-build/opus-build.pro
Expand Up @@ -15,13 +15,18 @@ SOURCEDIR=$$replace(BUILDDIR,-build,-src)
TEMPLATE = lib
CONFIG -= qt
CONFIG += debug_and_release
#CONFIG -= warn_on
#CONFIG += warn_off
CONFIG += no_include_pwd
VPATH = ../$$SOURCEDIR
TARGET = opus
DEFINES += HAVE_CONFIG_H

!CONFIG(third-party-warnings) {
# We ignore warnings in third party builds. We won't actually look
# at them and they clutter out our warnings.
CONFIG -= warn_on
CONFIG += warn_off
}

QMAKE_CFLAGS -= -fPIE -pie

win32 {
Expand Down

0 comments on commit fac930b

Please sign in to comment.