Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annoying problem with tray icon functionality on Windows #1452

Closed
Zuko opened this issue Oct 30, 2014 · 3 comments

Comments

@Zuko
Copy link
Contributor

commented Oct 30, 2014

After 06d9f7e if you click twice on mumble tray icon mumble window does not show again on next click (if its under other window). Only "fast" doubleclick causes this. We talk about it on IRC right after your @hacst commit.

Previous change was a lot worse. But this needs to be fixed.

@hacst hacst closed this in a120c8e Oct 30, 2014
@Zuko

This comment has been minimized.

Copy link
Contributor Author

commented Oct 30, 2014

Thanks ;)

@hacst

This comment has been minimized.

Copy link
Member

commented Oct 30, 2014

Turns out this broke the Mumble being able to raise itself above fullscreen windows on Windows (see 7d434bb). The issue with activateWindows is possibly a Qt bug and it that case fixing it in Qt should resolve this issue. I won't be able to spend more time on this in the near future so anyone else feel free to pick it up. Ideally a minimal example to reproduce the issue should be created to verify it is an issue with Qt and then reported as a bug.

@hacst hacst reopened this Oct 30, 2014
@Kissaki Kissaki added mumble ui labels Nov 1, 2014
unascribed added a commit to unascribed/mumble that referenced this issue Apr 7, 2016
When clicking the tray icon in rapid succession on
windows the next click on it wouldn't register.
Analysis showed the signal really didn't reach the
handler. It seems like there are some bad things
happening when calling activateWindow() in this
handler as when it is called this issue disappears.
As our setWindowState call should perform window
activation anyways we now simply rely on it and
remove the other call. Also unified both track
click handlers.

Fixes mumble-voip#1452
@davidebeatrici

This comment has been minimized.

Copy link
Member

commented Dec 2, 2017

Fixed in 90bef53.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.