New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Echo cancellation disabled in OSX #1775

Open
Toasty27 opened this Issue Aug 4, 2015 · 8 comments

Comments

Projects
None yet
8 participants
@Toasty27

Toasty27 commented Aug 4, 2015

I know this has been a long-running issue, but I didn't see any mention of it in closed or open tickets in Github.

The echo cancellation feature has been missing from OSX for a long time (forever?), since OSX doesn't offer a method for getting all the audio streams in the system through CoreAudio. There are other applications out there that can achieve this, but supposedly they use a lower-level interface than CoreAudio.

If this is impossible for some reason, please leave a detailed explanation so that others don't ask for this feature in the future. If there is no reason, then lets have a meaningful discussion on how to implement it.

@Ginja

This comment has been minimized.

Ginja commented Nov 24, 2015

+1

@mkrautz

This comment has been minimized.

Member

mkrautz commented Nov 24, 2015

We need to change the AudioUnit used in CoreAudio.cpp to use the VoiceProcessingIO audio unit. However, it is not as simple as just changing the audio unit subtype, which caused various problems -- the CoreAudio code needs to be reworked somehow.

I don't recall the problems encountered when simply switching the audio unit subtype, but I believe it simply "broke" audio output and/or input.

@mike-sol

This comment has been minimized.

mike-sol commented Nov 24, 2015

+1 from me as well, alas, I don't speak the languages needed to help fix this

@mkrautz

This comment has been minimized.

Member

mkrautz commented Nov 24, 2015

Also, the UI for Audio Input in the ConfigDialog needs to be able to show that it is using "System-provided Echo Cancellation".

@mkrautz mkrautz added this to the 1.3.0 milestone Jan 12, 2016

@mkrautz mkrautz self-assigned this Jan 12, 2016

@alakra

This comment has been minimized.

alakra commented Feb 19, 2017

👍

@tiagoefreitas

This comment has been minimized.

tiagoefreitas commented Aug 7, 2017

Any plans to fix this?

@saschaludwig

This comment has been minimized.

saschaludwig commented Feb 4, 2018

Maybe this year? - Please. <3

@crertel-packlane

This comment has been minimized.

crertel-packlane commented Apr 23, 2018

This would be absolutely wonderful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment