New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New server auto label #1645

Closed
wants to merge 5 commits into
base: master
from

Conversation

Projects
None yet
6 participants
@jumpandspintowin
Contributor

jumpandspintowin commented May 3, 2015

Adds a small new server workflow improvement by making server Label field optional and default to the hostname. This patch also moves the Label text box below the Username text box since it's no longer as important as the actual destination.

mumble-pr

@bendem

This comment has been minimized.

Contributor

bendem commented May 3, 2015

What if I connect to multiple servers on the same host?

@jumpandspintowin

This comment has been minimized.

Contributor

jumpandspintowin commented May 3, 2015

It'll use the same hostname as the label for each. I believe that is acceptable. Users know how to relabel things, but Mumble should at least handle the default case.

@bontibon

This comment has been minimized.

Member

bontibon commented May 3, 2015

Small bug: tabbing from the username field jumps over the label field.

@jumpandspintowin

This comment has been minimized.

Contributor

jumpandspintowin commented May 4, 2015

Thanks @bontibon, fixed.

@mkrautz

This comment has been minimized.

Member

mkrautz commented May 6, 2015

Feels weird to me that the label is at the bottom. But I think it's for the better...

I just duplicate the hostname to the label anyway.

@hacst

This comment has been minimized.

Member

hacst commented May 6, 2015

Two suggestions:

  • Would be cool if it would update the contents of the label field to stay in sync with the address unless the user changes it manually
  • I would drop the "(optional)" label. It'll mess up the layout (and translations) and won't really help the user much
@jumpandspintowin

This comment has been minimized.

Contributor

jumpandspintowin commented May 7, 2015

(1) I thought about doing this initially, but then thought it added complexity for no benefit. I've seen other applications use silent-defaults as well and it felt fine to me. If you think it's better then I can write that in.

(2) I'll do that.

@Githlar

This comment has been minimized.

Contributor

Githlar commented May 7, 2015

I think if you're going to drop "(optional)" than you may as well make Label auto-update. I think it would relay the intent that it's optional because, since it's the last item, if it's already filled out by the time the user really looks at it, chances are they won't mess with it unless they need/want to. Plus, it's not like it's resource-intensive.

If you're worried about undue complexity you could always just copy out the value of Address on whatever Qt's equivalent of blur() might be.

@jumpandspintowin

This comment has been minimized.

Contributor

jumpandspintowin commented May 7, 2015

Okay, label automatically updates. The flow is:

Initially "Label" will be filled in with "Server".

  • If "Label" is directly modified, it will no longer be updated to match "Server".
  • If "Label" is then cleared, it will then update with "Server" again. If the user clicks through without modifying "Server", the default logic will kick in and it'll equal Server anyways.

If a user Edits, the label is assumed to be custom and will not track the server unless cleared. I can change this to check if its equal to server if that is undesired, but I think this is intuitive.

@hacst hacst self-assigned this May 7, 2015

@hacst

This comment has been minimized.

Member

hacst commented May 7, 2015

Looks and feels great. Only thing I found was that when the add new dialog is initialized from a clipboard (the dialog will automatically pick up the info from a mumble url like mumble://testing:8000 if you have it in your clipboard) the url is set to custom. If the user had some random server in the clipboard and then edits the address he will end up with an unexpected label.

I'll fix this and land your patch.

@hacst

This comment has been minimized.

Member

hacst commented May 7, 2015

Merged as b2282e7 Move label to bottom of connect dialog and default it to hostname. I squashed the commit and wrote a new commit message. I hope you don't mind. Thanks a lot for your contribution.

Related to this commit are
78d0db8 Fix title from URLs not being picked up in connect dialog.
which fixes a Qt 5 transition related bug in the mime data decoding of the ConnectionDialog as well as
4e459a9 Do not consider a default hostname from clipboard to be custom
which fixes the behavioral issue I described above.

@hacst hacst closed this May 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment