Remove CELT 0.11.0 #2045
Merged
Remove CELT 0.11.0 #2045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidebeatrici
force-pushed
the
master
branch
from
55a6687
to
501651b
Compare
8 tasks
davidebeatrici
force-pushed
the
remove-celt-0.11.0
branch
2 times, most recently
from
e286e3e
to
706b5f7
Compare
CELT 0.11.0 provides better quality in comparison to CELT 0.7.0, but the two versions of the codecs are not compatible, which is why we provided both of them. Opus was introduced in Mumble 1.2.4 (7586a61), thus we expect that most (if not all) users are using it. By removing CELT 0.11.0 we don't break backwards compatibility, because it's provided by CELT 0.7.0. The main reason for removing the codec is the fact that its discontinued (in favor of Opus). Also, CELT 0.11.0 was removed from the Debian package back in 2012: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=682010
davidebeatrici
force-pushed
the
remove-celt-0.11.0
branch
from
706b5f7
to
9e1a560
Compare
|
I see the
Maybe it makes sense to unify them now? I haven’t looked at the code/separation. |
|
Lines 81 to 85 in 856eefa |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
CELT 0.11.0 provides better quality in comparison to CELT 0.7.0, but the two versions of the codecs are not compatible, which is why we provided both of them.
Opus was introduced in Mumble 1.2.4 (7586a61), thus we expect that most (if not all) users are using it.
By removing CELT 0.11.0 we don't break backwards compatibility, because it's provided by CELT 0.7.0.
The main reason for removing the codec is the fact that its discontinued (in favor of Opus).
Also, CELT 0.11.0 was removed from the Debian package back in 2012: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=682010
Discussion at #1999.