Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin update for latest version of Rocket League #2307

Closed
wants to merge 3 commits into from

Conversation

@davidebeatrici
Copy link
Member

commented May 25, 2016

Added:

  • Avatar position
  • Avatar front vector
  • Avatar top vector (calculated by Mumble using front vector)
  • Camera front vector
  • Camera top vector

Game Version: 1.18
http://www.rocketleaguegame.com/news/2016/05/patch-notes-v1-18-title-update-6/

Plugin update for latest version of Rocket League
Added:
- Avatar position
- Avatar front vector
- Camera front vector
- Camera top vector

Game Version: 1.18
http://www.rocketleaguegame.com/news/2016/05/patch-notes-v1-18-title-update-6/
@mkrautz

This comment has been minimized.

Copy link
Member

commented May 25, 2016

Can you save the file and add a version without spaces instead of tabs?

They add a lot of noise to the diff.

See
https://github.com/mumble-voip/mumble/pull/2307/files?w=1
vs
https://github.com/mumble-voip/mumble/pull/2307/files

@davidebeatrici

This comment has been minimized.

Copy link
Member Author

commented May 25, 2016

I think that the problem is of the previous code, that had spaces instead of tabs.
Do I need to replace tabs with spaces?

@mkrautz

This comment has been minimized.

Copy link
Member

commented May 25, 2016

No, the old code has tabs.
In this change, you're replacing them with spaces.

Fixed indentation
Tabs instead of spaces.
@davidebeatrici

This comment has been minimized.

Copy link
Member Author

commented May 25, 2016

Yes, you're right, I didn't know that Qt Creator uses spaces instead of tabs by default.
I fixed it 😉

Changed pointers
Previous ones where not working in every game mode.
@mkrautz

This comment has been minimized.

Copy link
Member

commented May 25, 2016

Landed via 3eec33a.

@mkrautz mkrautz closed this May 25, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.