Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overlay_gl: call glDrawArrays with GL_TRIANGLES instead of GL_QUADS. #2356

Merged
merged 1 commit into from Jun 23, 2016

Conversation

@mkrautz
Copy link
Member

commented Jun 19, 2016

GL_QUADS is deprecated in modern GL.

@mkrautz

This comment has been minimized.

Copy link
Member Author

commented Jun 19, 2016

@hacst

This comment has been minimized.

Copy link
Member

commented Jun 20, 2016

LGTM. Hardly have any clue about OpenGL though. Use matches OpenGL documentation ;) I take it we get away with the clockwise ordering because culling is disabled? As it was that way before it obviously works ;)

@mkrautz

This comment has been minimized.

Copy link
Member Author

commented Jun 20, 2016

Yep, I think that was the original assumption when the code was written.

@mkrautz mkrautz merged commit e13d6c9 into mumble-voip:master Jun 23, 2016

mkrautz added a commit that referenced this pull request Jun 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.