overlay: optimize blit() to not perform a blit if the active item rect is empty. #2364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
"It seems that in EVE Online, if we update our overlay texture but do not Should read: "It seems that in EVE Online, if we update our overlay texture but do not |
|
LGTM |
…t is empty. It seems that in EVE Online, if we update our overlay texture but do not draw to the screen, the texture mapping is never freed, until we begin drawing again. I do not know enough D3D11 to know why. Instead, this commit works around the issue by introducing a fully legal optimization to the blit() method: If the rect of active overlay elements is empty (that is, the screen is empty), do not perform a blit at all. The change also introduces an extra call to blit upon receiving OVERLAY_MSG_ACTIVE. That message is the message that signals that the rect of active elements has changed. We need to blit here to ensure we redraw correctly once the rect of active overlay elements changes. Fixes mumble-voip#1123
mkrautz
force-pushed
the
overlay-optimize-blit
branch
from
593e2e4
to
8272e48
Compare
|
Fixed the commit message. Will land. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that in EVE Online, if we update our overlay texture but do not
draw to the screen, the texture mapping is never freed.
I do not know enough D3D11 to know why.
Instead, this commit works around the issue by introducing a fully legal
optimization to the blit() method:
If the rect of active overlay elements is empty (that is, the screen is
empty), do not perform a blit at all.
The change also introduces an extra call to blit upon receiving
OVERLAY_MSG_ACTIVE. That message is the message that signals that
the rect of active elements has changed.
We need to blit here to ensure we redraw correctly once the rect
of active overlay elements changes.
Fixes #1123