Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OverlayClient: hide QGraphicsPixmapItems when FPS and time are disabled instead of setting an empty QPixmap. #2365

Merged
merged 1 commit into from Jul 2, 2016

Conversation

@mkrautz
Copy link
Member

commented Jun 25, 2016

Setting an empty QPixmap, at least in Qt 5, causes a great deal of
redraws. The QGraphicsScene triggers a changed() call, and
OverlayClient sends a blit request to the overlay library.

Before, any update to the invisible FPS counter or time view
would cause a full screen blit.

Now, when the overlay is truly empty (no FPS, time or users), no
messages are sent over the wire to the overlay library.

OverlayClient: hide QGraphicsPixmapItems when FPS and time are disabl…
…ed instead of setting an empty QPixmap.

Setting an empty QPixmap, at least in Qt 5, causes a great deal of
redraws. The QGraphicsScene triggers a changed() call, and
OverlayClient sends a blit request to the overlay library.

Before, any update to the invisible FPS counter or time view
would cause a full screen blit.

Now, when the overlay is truly empty (no FPS, time or users), no
messages are sent over the wire to the overlay library.
@mkrautz

This comment has been minimized.

Copy link
Member Author

commented Jun 25, 2016

@hacst

This comment has been minimized.

Copy link
Member

commented Jul 1, 2016

LGTM

@mkrautz mkrautz merged commit 27abc98 into mumble-voip:master Jul 2, 2016

mkrautz added a commit that referenced this pull request Jul 2, 2016
Merge PR #2365: OverlayClient: hide QGraphicsPixmapItems when FPS and…
… time are disabled instead of setting an empty QPixmap.

@davidebeatrici davidebeatrici added the Qt label Jul 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.