Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MainWindow: allow using F6 to switch between MainWindow's main widgets. #2411

Merged
merged 1 commit into from Jul 16, 2016

Conversation

@mkrautz
Copy link
Member

commented Jul 7, 2016

This new feature improves keyboard navigation in Mumble's main window
and is a great help to users of screen readers.

It was requested in #2291.

The behavior emulates Windows's (File) Explorer, where pressing F6
allows you to swtich focus between the application's main panes/panels.

In Mumble, pressing F6 switches between

Log view -> Chat input bar -> User tree view -> Log view [...]

Fixes part of #2291

@mkrautz

This comment has been minimized.

Copy link
Member Author

commented Jul 7, 2016

if (e->key() == Qt::Key_F6) {
focusNextMainWidget();
}
}

This comment has been minimized.

Copy link
@hacst

hacst Jul 8, 2016

Member

Should call baseclass implementation in else case.

@hacst

This comment has been minimized.

Copy link
Member

commented Jul 8, 2016

Funnily enough this is exactly what shift+tab does for me on Linux (while on windows it gets stuck in chatbar and adds tab characters). I wonder how our focus chain looks around there as QWidget *QWidget::nextInFocusChain() would be really convinient. Have you looked at that by any chance? I guess it might contain to much other stuff though if what we want is exclusively switching between these three.

Soo LGTM except comment.

@mkrautz

This comment has been minimized.

Copy link
Member Author

commented Jul 9, 2016

I'll test on Linux/Windows as well just to make sure I'm not doing something weird there. :-)

MainWindow: allow using F6 to switch between MainWindow's main widgets.
This new feature improves keyboard navigation in Mumble's main window
and is a great help to users of screen readers.

It was requested in #2291.

The behavior emulates Windows's (File) Explorer, where pressing F6
allows you to swtich focus between the application's main panes/panels.

In Mumble, pressing F6 switches between

  Log view -> Chat input bar -> User tree view -> Log view [...]

Fixes part of #2291

@mkrautz mkrautz force-pushed the mkrautz:f6-switch branch from 355bad7 to 615fe7f Jul 16, 2016

@mkrautz mkrautz merged commit 615fe7f into mumble-voip:master Jul 16, 2016

mkrautz added a commit that referenced this pull request Jul 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.