Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix updatecheck result logging #2424
Entirely drop the separate autoupdate logic, and no longer use the
Fixes unintended backwards logic of when to log result (by always logging as mentioned).
Three commits you may want to check individually. They also contain further info about the individual changes.
I don't get the removal of
There's a distinct difference between auto and non-auto:
For auto=1 we shouldn't output anything if we're on the latest version.
For auto=0, it should output the $latest line.
Can you please elaborate?
Otherwise the two other commits LGTM (with my comments addressed).
1 similar comment
It merges the case