Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LCD: add workarounds for LCD drawing on Qt 5.6. #2430

Merged
merged 1 commit into from Jul 16, 2016

Conversation

@mkrautz
Copy link
Member

commented Jul 15, 2016

This is a temporary workaround until we can get the issue fixed
upstream.

See #2429 for more information.

@mkrautz mkrautz force-pushed the mkrautz:lcd-drawing-qt56 branch from a780bf3 to 89e648c Jul 15, 2016

@mkrautz

This comment has been minimized.

Copy link
Member Author

commented Jul 15, 2016

With this applied:

image

@mkrautz

This comment has been minimized.

Copy link
Member Author

commented Jul 15, 2016

Without this applied:

image

Note: inverted image, no text.

LCD: add workarounds for LCD drawing on Qt 5.6.
This is a temporary workaround until we can get the issue fixed
upstream.

See #2429 for more information.

@mkrautz mkrautz force-pushed the mkrautz:lcd-drawing-qt56 branch from 89e648c to c04aa4e Jul 15, 2016

@mkrautz

This comment has been minimized.

Copy link
Member Author

commented Jul 15, 2016

@mkrautz

This comment has been minimized.

Copy link
Member Author

commented Jul 15, 2016

As a point of reference, this is how the broken state looks on-device, via #2386 (comment)

image

@mkrautz

This comment has been minimized.

Copy link
Member Author

commented Jul 16, 2016

It's also worth noting, this patch restores the look of 1.2.x.

@hacst

This comment has been minimized.

Copy link
Member

commented Jul 16, 2016

So inverting one QPixmap screws up rendering of the whole thing? That's kinda strange. LGTM as a workaround though we should definitely investigate where this comes from.

@mkrautz

This comment has been minimized.

Copy link
Member Author

commented Jul 16, 2016

No, the rendering is screwed up in Qt 5.6 in general.

I.e., I have to use Qt::white instead of Qt::color1 AND I have to invert the pixmap...

@mkrautz

This comment has been minimized.

Copy link
Member Author

commented Jul 16, 2016

Our bug is at #2429

@mkrautz mkrautz merged commit c04aa4e into mumble-voip:master Jul 16, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.