Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugins: allow getModuleAddr() to enumerate 32-bit modules in WoW64 mode. #2442

Merged
merged 1 commit into from Jul 18, 2016

Conversation

@mkrautz
Copy link
Member

commented Jul 18, 2016

Include TH32CS_SNAPMODULE32 in call to CreateToolhelp32Snapshot.

This fixes module enumeration in getModuleAddr().

Without this flag, if called from a WoW64 process, we'll only see the
64-bit DLLs of the process (i.e., WoW64 specific DLLs) such as:

ntdll.dll
wow64.dll
wow64win.dll
wow64cpu.dll

and nothing else.

With this flag, we get everything.

Fixes #2437

plugins: allow getModuleAddr() to enumerate 32-bit modules in WoW64 m…
…ode.

Include TH32CS_SNAPMODULE32 in call to CreateToolhelp32Snapshot.

This fixes module enumeration in getModuleAddr().

Without this flag, if called from a WoW64 process, we'll only see the
64-bit DLLs of the process (i.e., WoW64 specific DLLs) such as:

  ntdll.dll
  wow64.dll
  wow64win.dll
  wow64cpu.dll

and nothing else.

With this flag, we get everything.

Fixes #2437
@mkrautz

This comment has been minimized.

Copy link
Member Author

commented Jul 18, 2016

@davidebeatrici

This comment has been minimized.

Copy link
Member

commented Jul 18, 2016

Working fine, LGTM 😉

@mkrautz mkrautz merged commit bb72d91 into mumble-voip:master Jul 18, 2016

mkrautz added a commit that referenced this pull request Jul 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.