Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset to 0 dB on Local Volume Adjustment reset button #2518

Merged
merged 1 commit into from Aug 19, 2016

Conversation

@while-loop
Copy link
Contributor

commented Aug 18, 2016

When pressing the Reset button in Local Volume Adjustment, it now resets to 0 instead of the modified value.

Feature #2461

Reset to 0 dB on localvoladj reset
When pressing the Reset button in Local Volume Adjustment, it now resets to 0 instead of the modified value
@Calves95

This comment has been minimized.

Copy link

commented Aug 19, 2016

I never really noticed but this is true, reset could be 0 and cancel is just like the current reset. Like reset seems like a "reset to default" button. Good find on last pull and good fix.

@mkrautz

This comment has been minimized.

Copy link
Member

commented Aug 19, 2016

LGTM.

Thanks for doing this!

@mkrautz mkrautz merged commit 1603d08 into mumble-voip:master Aug 19, 2016

@while-loop while-loop deleted the while-loop:feature-reset-to-0 branch Aug 25, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.