Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various warnings in the Windows overlay found by upgrading to MSVC2015 #2525

merged 3 commits into from Aug 24, 2016


Copy link

commented Aug 21, 2016

Add LONG cast when creating RECT.

Before re-defining _WIN32_WINNT, undef it first, if it's already set.

Use unsigned long long in HANDLE conversion code in overlay_exe to avoid casting from a pointer to a smaller-than-pointer-sized integer.

mkrautz added 3 commits Aug 21, 2016
overlay/overlay_exe: use unsigned long long for our passed-in handle …
…to silence MSVC2015 warning.

    warning C4312: 'reinterpret_cast': conversion from 'unsigned long' to 'HANDLE' of greater size

Also, please note the comment in src/mumble/Overlay_win.cpp regarding the
32-bit masking: says:
> When sharing a handle between 32-bit and 64-bit applications, only
> the lower 32 bits are significant [...]

This comment has been minimized.

Copy link

commented Aug 24, 2016


mkrautz added a commit that referenced this pull request Aug 24, 2016
Merge PR #2527: Allow Mumble to be built with MSVC2015
This PR adds a toolchain file, and includes various small fixups that are needed to make Mumble build on MSVC2015.

This PR, by itself, allows both Mumble and Murmur to build, but the x64 overlay and some plugins do not build without extra PRs. These are:


MSVC2015 also shows a few new warnings. These are fixed in the following PRs:

And, to finish off, PR #2526 enables warnings by default on Windows when in a buildenv. I used this when fixing the tree.

@mkrautz mkrautz merged commit dd14796 into mumble-voip:master Aug 24, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
3 participants
You can’t perform that action at this time.