Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log information about missing target channel #2580

Merged
merged 1 commit into from Oct 20, 2016

Conversation

@Kissaki
Copy link
Member

commented Oct 18, 2016

For lack of better presentation, I implemented it as a simple log information. A dialog would be more prominent/visible, but equally more annoying. On connectivity issues with (some kind of) dynamic channels this could be pretty annoying as well (server reconnects). A log message is the less intrusive way to inform.

Fixes #2577 E.g. when connecting via Mumble URL and the target channel does not exist

Log information about missing target channel
E.g. when connecting via Mumble URL and the target channel does not exist

Fixes #2577
@mkrautz
Copy link
Member

left a comment

LGTM

@mkrautz mkrautz merged commit 4add9ce into mumble-voip:master Oct 20, 2016

@Kissaki Kissaki deleted the Kissaki:notify-missing-target-channel branch Oct 20, 2016

Kissaki added a commit that referenced this pull request Nov 5, 2016
Fix #2584 by reverting introduction of log message with PR #2580
The logic does not handle all cases. Specifically, it does not handle
the normal connect case correctly (which is a "not found" case as well)

When working on a fix, more changes seemed reasonable, which resulted
in PR #2590 which is not trivial and not ready yet.

In order for the issue #2584 to not persist longer than necessary, revert
the change that introduced it. The PR #2590 will reintroduce the log
message and other changes later on.

This reverts commit 9c5d02c
(merge commit 4add9ce)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.