Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugins: Build x64 ones only when the target is x86_64 #2607

Merged
merged 1 commit into from Oct 29, 2016

Conversation

@davidebeatrici
Copy link
Member

commented Oct 29, 2016

x64 plugins only work if Mumble is x64 too, this means that we should avoid building them with Mumble x86.

davidebeatrici added a commit to davidebeatrici/mumble-releng that referenced this pull request Oct 29, 2016

@davidebeatrici davidebeatrici force-pushed the davidebeatrici:x64-plugins-check branch from c107b39 to eda1710 Oct 29, 2016

</ComponentGroup>
<?if $(sys.BUILDARCH) = "x64" ?>

This comment has been minimized.

Copy link
@mkrautz

mkrautz Oct 29, 2016

Member

Is it valid to redefine the PluginFolder directoryref, and the Plugins componentgroup? This seems wrong.

I would simply group the x64 plugins together inside <?if $(sys.BUILDARCH) = "x64" ?>...<?endif > in each of them (one on the DirectoryRef, one in the ComponentGroup)...

Does this build?

This comment has been minimized.

Copy link
@davidebeatrici

davidebeatrici Oct 29, 2016

Author Member

Sadly I can't try it, as I don't have a Mumble build environment on Windows.

@davidebeatrici davidebeatrici force-pushed the davidebeatrici:x64-plugins-check branch from eda1710 to 2293695 Oct 29, 2016

davidebeatrici added a commit to davidebeatrici/mumble-releng that referenced this pull request Oct 29, 2016
plugins: build x64 ones only when the target is x86_64
x64 plugins only work if Mumble is x64 too, this means that we should avoid building them with Mumble x86.

@davidebeatrici davidebeatrici force-pushed the davidebeatrici:x64-plugins-check branch from eea24ac to 882ad70 Oct 29, 2016

@mkrautz mkrautz merged commit b96bd07 into mumble-voip:master Oct 29, 2016

@davidebeatrici davidebeatrici deleted the davidebeatrici:x64-plugins-check branch Oct 30, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.