Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overlay: fall back to fxc.exe on PATH if DXSDK is not set. #2634

Merged
merged 1 commit into from Nov 13, 2016

Conversation

@mkrautz
Copy link
Member

commented Nov 13, 2016

This allows the overlay to build with the Windows SDK version
of fxc.exe.

This removes the need for people developing locally to install
the legacy DirectX SDK.

@@ -50,7 +50,11 @@ CONFIG(debug, debug|release) {

# Override fxc binary for the x86 build.
CONFIG(force-x86-toolchain) {
FXC = "\"$$(DXSDK_DIR)\\Utilities\\bin\\x86\\fxc.exe\""
exists($$(DXSDK_DIR)) {

This comment has been minimized.

Copy link
@mkrautz

mkrautz Nov 13, 2016

Author Member

no parens here

overlay: fall back to fxc.exe on PATH if DXSDK is not set.
This allows the overlay to build with the Windows SDK version
of fxc.exe.

This removes the need for people developing locally to install
the legacy DirectX SDK.

@mkrautz mkrautz force-pushed the mkrautz:allow-winsdk-fxc branch from 2655d65 to d9cc484 Nov 13, 2016

@mkrautz mkrautz merged commit 380cd6b into mumble-voip:master Nov 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.