Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings: add workaround for macOS "@Variant(" bug. #2687

Merged
merged 1 commit into from Dec 2, 2016

Conversation

@mkrautz
Copy link
Member

commented Dec 2, 2016

Qt expects to be able to write NUL bytes in strings
serialized via QSettings. macOS Sierra broke this.

We've since backported a fix from Qt master into
our buildenv, and the bug is fixed.

This commit adds a workaround for users whose clients
have already written 'bad' config files on macOS.

If a bad config value is detected, it is skipped and
the default is used instead.

Settings: add workaround for macOS "@variant(" bug.
Qt expects to be able to write NUL bytes in strings
serialized via QSettings. macOS Sierra broke this.

We've since backported a fix from Qt master into
our buildenv, and the bug is fixed.

This commit adds a workaround for users whose clients
have already written 'bad' config files on macOS.

If a bad config value is detected, it is skipped and
the default is used instead.

@mkrautz mkrautz merged commit 06d3785 into mumble-voip:master Dec 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.