Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Developer Console to Mumble #2698

Merged
merged 4 commits into from Dec 4, 2016

Conversation

@mkrautz
Copy link
Member

commented Dec 4, 2016

No description provided.

@mkrautz mkrautz force-pushed the mkrautz:in-client-log-mumble branch 4 times, most recently from 8bd8b90 to 6385ae0 Dec 4, 2016

mkrautz added 4 commits Dec 4, 2016
Add LogEmitter to Mumble and use it in os_win.cpp.
This is in preparation for the Developer Console.
Add Developer Console to Mumble, where users can inspect Mumble's log…
… output.

We already log to Windows's debug log, but this is a little more
accessible for regular users and developers alike. (Sometimes, you don't
have DebugView handy...)

@mkrautz mkrautz force-pushed the mkrautz:in-client-log-mumble branch from 6385ae0 to f62af9a Dec 4, 2016

@mkrautz mkrautz merged commit 6ac0553 into mumble-voip:master Dec 4, 2016

@dstensnes

This comment has been minimized.

Copy link

commented Dec 6, 2016

Broken? For me fails to build because of line 11 in src/mumble/DeveloperConsole.cpp:
m_window.clear();

Function is undefined apparently. Running Debian 8.

UPDATED: typo in function call...

@mkrautz

This comment has been minimized.

Copy link
Member Author

commented Dec 6, 2016

We should be able to remove that line to fix the Qt 4 build.

@dstensnes

This comment has been minimized.

Copy link

commented Dec 6, 2016

I replaced it with

m_window->clearFocus();
m_window->close();

but not sure if that is needed, as I have very little experience with qt. It has been running fine all day though, even though I have opened that window a couple of times. So, I am totally not helpful here....

@mkrautz

This comment has been minimized.

Copy link
Member Author

commented Dec 8, 2016

Fixed in the tree, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.