Mumble.proto: explicitly use proto2 syntax. #2742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kissaki
approved these changes
Jan 20, 2017
|
The proto3 docs describe specifying proto3 syntax, and that proto2 will implicitly be used if not specified. Is the use of |
|
@Kissaki Yes, I'll amend the commit with more info:
Why? Is it safe? |
The protoc compiler in protobuf 3.x.y complains (warns) about Mumble.proto not explicitly specifying a syntax. This commit fixes that. The syntax=XXX declaration is mentioned in language spec for proto 2, so this should still work for protobuf 2.6, etc. See https://developers.google.com/protocol-buffers/docs/reference/proto2-spec
mkrautz
force-pushed
the
mumble-proto-proto2
branch
from
b686ec7
to
4e6d3bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.