Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow hiding Muble from the menu without minimizing #2747

Merged
merged 1 commit into from Jan 22, 2017

Conversation

@Piratonym
Copy link
Contributor

commented Jan 21, 2017

Add a new entry to the menu, allowing users to hide Mumble without minimizing it.

This is especially useful for users with a window manager that does not support minimizing windows, as these users were previously unable to hide Mumble. Mumble can (as always) be restored by clicking on the tray icon (if present) or starting Mumble again (without the --multiple switch). Fixes #2737.

A possible further change would be to change the "Minimize" option in the closing dialogue to "Hide", which I feel would be more appropriate in most cases. Also, a shortcut could be added to hide Mumble directly.

@mkrautz
Copy link
Member

left a comment

LGTM, but there's a problem on macOS. macOS has native "hide" functionality in its "window manager" (Cmd-H).

The hide feature from this PR doesn't work on macOS -- there is literally no way for me to bring the window back. Clicking the dock icon doesn't work, and since there is no tray icon for Mumble on macOS, I can't click that either.

I'll follow up with a fix for that problem.
Code LGTM.

@mkrautz mkrautz merged commit bf90fad into mumble-voip:master Jan 22, 2017

@Piratonym Piratonym deleted the Piratonym:feature-hide-from-menu branch Apr 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.