Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Allow hiding Muble from the menu without minimizing #2747
Add a new entry to the menu, allowing users to hide Mumble without minimizing it.
This is especially useful for users with a window manager that does not support minimizing windows, as these users were previously unable to hide Mumble. Mumble can (as always) be restored by clicking on the tray icon (if present) or starting Mumble again (without the --multiple switch). Fixes #2737.
A possible further change would be to change the "Minimize" option in the closing dialogue to "Hide", which I feel would be more appropriate in most cases. Also, a shortcut could be added to hide Mumble directly.
mkrautz left a comment
LGTM, but there's a problem on macOS. macOS has native "hide" functionality in its "window manager" (Cmd-H).
The hide feature from this PR doesn't work on macOS -- there is literally no way for me to bring the window back. Clicking the dock icon doesn't work, and since there is no tray icon for Mumble on macOS, I can't click that either.
I'll follow up with a fix for that problem.