Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugins: Fix visibility, warnings and errors when compiled with MinGW #2755

Merged
merged 2 commits into from Jan 22, 2017

Conversation

@davidebeatrici
Copy link
Member

commented Jan 22, 2017

warning: converting to non-pointer type 'procptr32_t {aka long unsigned int}' from NULL [-Wconversion-null]`
ql\ql.cpp:87: warning: comparison is always true due to limited range of data type [-Wtype-limits]
  if (team >= 0 && team <= 3) {
sto\sto.cpp:11: error: 'numeric_limits' is not a member of 'std'
  if (src.length() > static_cast<size_t>(std::numeric_limits<int>::max())) {

Not fixed:

sto\sto.cpp:55: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
  if (* reinterpret_cast<DWORD *>(& posblock[52]) == 1) {
plugins: Fix MinGW compilation warnings and errors
warning: converting to non-pointer type 'procptr32_t {aka long unsigned int}' from NULL [-Wconversion-null]
ql\ql.cpp:87: warning: comparison is always true due to limited range of data type [-Wtype-limits]
sto\sto.cpp:11: error: 'numeric_limits' is not a member of 'std'

Not fixed:
sto\sto.cpp:55: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
@mkrautz

This comment has been minimized.

Copy link
Member

commented Jan 22, 2017

LGTM

@mkrautz mkrautz merged commit 98349a1 into mumble-voip:master Jan 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.