Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rcc.pri: Fix script path for MinGW on Linux #2771

Merged
merged 1 commit into from Jan 25, 2017

Conversation

@davidebeatrici
Copy link
Member

commented Jan 25, 2017

This fixes a problem with MinGW on Linux where it can't find the script file, because of the backslashes.
Windows handles the path correctly with both methods.

rcc.pri: Fix script path for MinGW on Linux
This fixes a problem with MinGW on Linux where it can't find the script file, because of the backslashes.
Windows handles the path correctly with both methods.
RCC_DEPENDS = $$escape_expand(\")$${PWD}/scripts/rcc-depends.py$$escape_expand(\")
rcc.depend_command = $${RCC_DEPENDS} ${QMAKE_FILE_IN}
}
RCC_DEPENDS = $$escape_expand(\")$${PWD}/scripts/rcc-depends.py$$escape_expand(\")

This comment has been minimized.

Copy link
@mkrautz

mkrautz Jan 25, 2017

Member

This seems wrong. On Windows $PWD will be with backslashes, so you're construction a path c:\that\looks\like/this/scripts/rcc-depends.py

This comment has been minimized.

Copy link
@mkrautz

mkrautz Jan 25, 2017

Member

Actually, it uses forward slashes on Windows with qmake.
LGTM.

Actually $$PWD might be with forward slashes since it's a qmake variable

RCC_DEPENDS = $$escape_expand(\")$${PWD}/scripts/rcc-depends.py$$escape_expand(\")
rcc.depend_command = $${RCC_DEPENDS} ${QMAKE_FILE_IN}
}
RCC_DEPENDS = $$escape_expand(\")$${PWD}/scripts/rcc-depends.py$$escape_expand(\")

This comment has been minimized.

Copy link
@mkrautz

mkrautz Jan 25, 2017

Member

Actually, it uses forward slashes on Windows with qmake.
LGTM.

@mkrautz mkrautz merged commit 7e1fdaa into mumble-voip:master Jan 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.