mumble_plugin_win32_ptr_type.h: Prevent redefinition of "NOMINMAX" #2790

Merged
merged 1 commit into from Feb 2, 2017

Projects

None yet

3 participants

@davidebeatrici
Member

Define "NOMINMAX" only if it isn't already.
MinGW defines it by default, which results in the following warning:

warning: "NOMINMAX" redefined
@mkrautz
Member
mkrautz commented Jan 30, 2017

Could you add the commit message as a comment, also?

So it comes something like:

// Define "NOMINMAX" only if it isn't already.
// MinGW defines it by default, which results in a redefinition warning.
#ifndef NOMINMAX
# define NOMINMAX
#endif
@Kissaki
Member
Kissaki commented Jan 31, 2017 edited

Nitpick:
I would prefer not to put that long filename into the commit summary line.
Is it important that it is specifically that file? So important it should be in the summary line?
In other commits you used "plugins: [...]".

@davidebeatrici
Member

No, it isn't important.
The filename is very long, indeed, I'm going to replace it with "plugins" right now.

@davidebeatrici davidebeatrici plugins: Prevent redefinition of "NOMINMAX"
Define "NOMINMAX" only if it isn't already.
MinGW defines it by default, which results in the following warning:
warning: "NOMINMAX" redefined
2213d50
@mkrautz
mkrautz approved these changes Feb 2, 2017 View changes
@mkrautz mkrautz merged commit 1be562f into mumble-voip:master Feb 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment