Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update country flag icons #2791

Merged
merged 1 commit into from Jan 30, 2017

Conversation

@Kissaki
Copy link
Member

commented Jan 30, 2017

Update the flags with our script extract-emojione-flags.py from the most recent emojione version 2.2.7.

Emojione changed from rectangle flags to round representations.

Fixes #2732

Previously, the mumble_flags.qrc was split into several files, generated
by mkflags.py. This will now generate only one qrc file because the svg
files are substantially reduced in size, all together 440.638 bytes in
size (so the workaround would actually no longer be necessary, and we
actually get only one qrc file).

Before and after:

2017-01-30 16_47_38-mumble server connect 2017-01-30 18_42_05-mumble server connect

Update country flag icons
Update the flags with our script extract-emojione-flags.py from the most recent emojione version 2.2.7.

Emojione changed from rectangle flags to round representations.

Fixes #2732

Previously, the mumble_flags.qrc was split into several files, generated
by mkflags.py. This will now generate only one qrc file because the svg
files are substantially reduced in size, all together 440.638 bytes in
size (so the workaround would actually no longer be necessary, and we
actually get only one qrc file).

@Kissaki Kissaki added the ui label Jan 30, 2017

@Kissaki Kissaki requested review from mkrautz and hacst Jan 30, 2017

@mkrautz
Copy link
Member

left a comment

LGTM

@mkrautz mkrautz merged commit 867d4f6 into mumble-voip:master Jan 30, 2017

@Kissaki Kissaki deleted the Kissaki:flag-icons branch Jan 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.