Add missing include #2805

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@Kissaki
Member
Kissaki commented Feb 3, 2017

While the code compiled on Windows, it does not on (some) other systems.

This should fix our PPA build.
See log https://launchpadlibrarian.net/305049230/buildlog_ubuntu-precise-i386.mumble_1.3.0~1902~gd871f34~snapshot-1~ppa1~precise1_BUILDING.txt.gz

@Kissaki Kissaki Add missing include
While the code compiled on Windows, it does not on (some) other systems.
c7d8a6c
@Kissaki Kissaki added build code labels Feb 3, 2017
@Kissaki Kissaki requested a review from mkrautz Feb 3, 2017
@mkrautz

No, as you can see from the build log, QFileInfo is included:

https://launchpadlibrarian.net/305049425/buildlog_ubuntu-precise-armhf.mumble_1.3.0~1902~gd871f34~snapshot-1~ppa1~precise1_BUILDING.txt.gz

The problem is that the static QFileInfo::exists you're using doesn't exist in Qt 4. I guess we need a QFile for that?

@mkrautz
Member
mkrautz commented Feb 3, 2017

Sorry. Not a QFile. We need a QFileInfo instance...

@Kissaki Kissaki closed this Feb 3, 2017
@Kissaki Kissaki deleted the Kissaki:add-include branch Feb 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment