Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlay_win.cpp: Fix MinGW compilation warning #2811

Conversation

@davidebeatrici
Copy link
Member

commented Feb 4, 2017

Overlay_win.cpp:184:9: warning: enumeration value 'UnknownError' not handled in switch [-Wswitch]
switch (processError) {
^

Overlay_win.cpp: Fix MinGW compilation warning
Overlay_win.cpp:184:9: warning: enumeration value 'UnknownError' not handled in switch [-Wswitch]
  switch (processError) {
         ^

@davidebeatrici davidebeatrici added the build label Feb 4, 2017

@hacst
hacst approved these changes Feb 4, 2017
Copy link
Member

left a comment

LGTM. We could add a default and drop the return but I prefer it this way. If QProcess ever gets new enum keys we'll be "notified" by the compiler.

@davidebeatrici davidebeatrici merged commit b817d3f into mumble-voip:master Feb 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.