Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installer: use WiX from buildenv. #2817

Merged
merged 1 commit into from Feb 9, 2017

Conversation

@mkrautz
Copy link
Member

commented Feb 5, 2017

Previously, we required people to install WiX globally.
That's yet another tedious dependency required in order to build Mumble.

We'll now be distributing WiX in our buildenvs, so tell our .wixproj
to use that version.

@hacst
hacst approved these changes Feb 5, 2017
Copy link
Member

left a comment

Please mention http://wixtoolset.org/documentation/manual/v3/msbuild/daily_builds.html somewhere in the commit message. LGTM otherwise.

@mkrautz mkrautz changed the title installer: use WiX from buildenv. WIP: installer: use WiX from buildenv. Feb 5, 2017

@mkrautz

This comment has been minimized.

Copy link
Member Author

commented Feb 5, 2017

Marked as WIP for now. If we land this, we'll require a buildenv update...

installer: use WiX from buildenv.
This uses the mechanism documented at
http://wixtoolset.org/documentation/manual/v3/msbuild/daily_builds.html
to use a local copy of WiX instead of using the WiX MSI package.

Previously, we required people to install WiX globally.
That's yet another tedious dependency required in order to build Mumble.

We'll now be distributing WiX in our buildenvs, so tell our .wixproj
to use that version.

@mkrautz mkrautz force-pushed the mkrautz:buildenv-wix-v2 branch from 8425e42 to e4fe8fb Feb 5, 2017

@mkrautz

This comment has been minimized.

Copy link
Member Author

commented Feb 5, 2017

I'll land this after we land the app-local UCRT PR, once we have a snapshot with it in released.

@mkrautz mkrautz changed the title WIP: installer: use WiX from buildenv. installer: use WiX from buildenv. Feb 9, 2017

@mkrautz mkrautz merged commit 81f36bb into mumble-voip:master Feb 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.