installer: don't ship dbghelp.dll anymore. #2835

Merged
merged 1 commit into from Feb 9, 2017

Projects

None yet

1 participant

@mkrautz
Member
mkrautz commented Feb 9, 2017

Only older versions of dbghelp.dll are redistributable by themselves.
Newer versions only allow redistribution via MSI files, which are
useless for us.

To sidestep this problem, we'll simply go back to relying on the OSes
version of dbghelp.dll. Shipping an outdated version of dbghelp.dll
isn't sensible. We're better off allowing Windows 10 to use a modern
(its own) version of dbghelp.dll than using a year-old version.

To give some context on how we use dbghelp.dll:

In Mumble, we use dbghelp.dll for writing our Minidumps.

In Murmur, Ice uses it for symbolicating stack traces in
Ice exceptions.

@mkrautz mkrautz installer: don't ship dbghelp.dll anymore.
Only older versions of dbghelp.dll are redistributable by themselves.
Newer versions only allow redistribution via MSI files, which are
useless for us.

To sidestep this problem, we'll simply go back to relying on the OSes
version of dbghelp.dll. Shipping an outdated version of dbghelp.dll
isn't sensible. We're better off allowing Windows 10 to use a modern
(its own) version of dbghelp.dll than using a year-old version.

To give some context on how we use dbghelp.dll:

In Mumble, we use dbghelp.dll for writing our Minidumps.

In Murmur, Ice uses it for symbolicating stack traces in
Ice exceptions.
18caa17
@mkrautz mkrautz merged commit 5bbd804 into mumble-voip:master Feb 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment