Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Various minor fixes in preparation for hot-cert reload #2879
4 times, most recently
Feb 26, 2017
Kissaki left a comment
A QSettings that is not the one known to Meta? Seems strange with Meta still holding a QSettings. Will have to see how it looks when used.
Commit 3 d5b773c has a logically duplicate paragraph it seems.
Commit 4 4e3b6c0 says hot reloading will only be possible for meta certs. Why? Does it mean the new codepath that will be added via usr signal? Isn't hot loading already possible for vservers?
Commit 5 fdc87ad "in order to re-load the
Meta.cpp#L156 and L161 should be
We are only using the ciphers list in two places:
Shouldn't there also be our initial server listening?
We need to reload the settings. The way that happens is that I create a new QSettings and update the MetaParams with the new SSL settings.
I don't even think MetaParam's own QSettings object is necessary once we've called MetaParams:.read(), will look into it...
Kinda. When I say hot cert reloading, I mean the "send USR1 to the murmur process to reload the cert files specified in murmur.ini".
Should I be more specific? The USR1 signal will not load certs for vservers, since they can't change without using RPC, and if you're using RPC, you should use the updateCertificate() server method instead.
Qt doesn't provide a SSL server socket, so the way we do it is we have a TCP server, and for each incoming connection, we wrap it in QSslSocket to "upgrade" it to a SSL connection.
Yes, I think so.
implies there is no live reloading for vservers, when it's just a different mechanism (that already can live reload/set). Not sure how to formulate (point to separate mechanism, or word differently...).
Rewrote the commit messages.
The new changes are committed to this branch (hot-reload-certs-prep), but they're also available in https://github.com/mkrautz/mumble/tree/hot-reload-certs-prep-v3
v1: https://github.com/mkrautz/mumble/tree/hot-reload-certs-prep-v1 (old)