Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installer: quote GUIDs in Settings.wxi. #2902

Merged
merged 1 commit into from Jul 17, 2018

Conversation

@mkrautz
Copy link
Member

commented Mar 4, 2017

No description provided.

@davidebeatrici

This comment has been minimized.

Copy link
Member

commented May 31, 2017

Why is this a WIP?

@mkrautz

This comment has been minimized.

Copy link
Member Author

commented Jun 1, 2017

Because the author isn't sure this is valid.

Are you?

@davidebeatrici

This comment has been minimized.

Copy link
Member

commented Jul 17, 2018

According to https://docs.microsoft.com/en-us/windows/desktop/Msi/guid:

The GUID data type is a text string representing a Class identifier (ID). COM must be able to convert the string to a valid Class ID. All GUIDs must be authored in uppercase.

The valid format for a GUID is {XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX} where X is a hex digit (0,1,2,3,4,5,6,7,8,9,A,B,C,D,E,F).

Note that utilities such as GUIDGEN can generate GUIDs containing lowercase letters. These must all be changed to uppercase letters before the GUID can be used by the installer as a valid product code, package code, or component code.

The WiX compiler takes care of converting the string to the right format.

@davidebeatrici davidebeatrici changed the title WIP: installer: quote guids in Settings.wxi. installer: quote GUIDs in Settings.wxi. Jul 17, 2018

@davidebeatrici davidebeatrici merged commit 91601a1 into mumble-voip:master Jul 17, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.