Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlay_win: properly initialize m_helper_enabled, m_helper64_enabled and m_mumble_handle. #2921

Merged
merged 1 commit into from Mar 11, 2017

Conversation

@mkrautz
Copy link
Member

commented Mar 11, 2017

We neglected to properly initialize these variables in OverlayPrivateWin,
causing the overlay helpers to sometimes not be launched.

@mkrautz mkrautz requested review from Kissaki, hacst and davidebeatrici Mar 11, 2017

Overlay_win: properly initialize m_helper_enabled, m_helper64_enabled…
… and m_mumble_handle.

We neglected to properly initialize these variables in OverlayPrivateWin,
causing the overlay helpers to sometimes not be launched.

Fixes #2911

@mkrautz mkrautz force-pushed the mkrautz:overlay-win-initialize branch from 9788543 to b3f2833 Mar 11, 2017

@Kissaki

This comment has been minimized.

Copy link
Member

commented Mar 11, 2017

I'd prefer a shorter summary line in the commit, but that's ok.

@mkrautz mkrautz merged commit bed0869 into mumble-voip:master Mar 11, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.