Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting for enabling the Developer menu #2926

Merged
merged 3 commits into from Mar 13, 2017

Conversation

@mkrautz
Copy link
Member

commented Mar 12, 2017

Prior to this PR, the Developer menu was always enabled.
That was OK for snapshots, but for release, we're going to want it disabled by default.

This PR....

  • Adds a new setting, 'ui/developerconsole' for enabling the Developer menu.
  • Adds a checkbox in LookConfig and hooks it up to the 'ui/developerconsole' setting.
  • Hooks up MainWindow to dynamically show/hide the Developer menu depending on the state of 'ui/developerconsole'.
mkrautz added 3 commits Mar 12, 2017
Settings: add setting for enabling developer menu.
This setting allows users to enable the "Developer" menu.
The Developer menu currently only contains the Developer Console,
which is an easy way to see Mumble's log output from inside Mumble.
MainWindow: implement UI logic for 'ui/developermenu' setting.
qmDeveloper is now dynamically added and removed from MainWindow
depending on the state of the 'ui/developermenu' setting.

@mkrautz mkrautz requested review from Kissaki, hacst and davidebeatrici Mar 12, 2017

@davidebeatrici davidebeatrici added the ui label Mar 12, 2017

@mkrautz mkrautz merged commit dbab0f7 into mumble-voip:master Mar 13, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.