Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Implement QtSpeech-based text-to-speech backend #2939
Qt 5.8 introduced Qt Speech, a module that contains a TTS system which works on every OS.
This commit provides a new file called "TextToSpeech.cpp", without any suffix, indicating that it is OS-independent.
mkrautz left a comment
A few coding style comments...
changed the title
Use Qt Speech if available, instead of OS-specific TTS systems
Mar 14, 2017
The commit message is still not 100% true. It says this new implementation will only be used if you have CONFIG+=qtspeech AND have the module available.
However, if you use CONFIG+=qtspeech, and the module is not available -- it will not build correctly, and fail during the build, because the Qt module isn't available.
I suggest you add an else clause to the Qt module check, and error() if the module is not available.
How about this commit message instead?