Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MurmurIce: fix signed/unsigned comparison between string size and std::numeric_limits. #2956

Merged
merged 1 commit into from Mar 18, 2017

Conversation

@mkrautz
Copy link
Member

commented Mar 18, 2017

std::numeric_limit's max() method return a T, so when comparing it against
a container size, we have to cast it to size_t.

This is currently breaking the win32-static (32-bit) build.

MurmurIce: fix signed/unsigned comparison between string size and std…
…::numeric_limits.

std::numeric_limit's max() method return a T, so when comparing it against
a container size, we have to cast it to size_t.

This is currently breaking the win32-static (32-bit) build.

@mkrautz mkrautz force-pushed the mkrautz:signed-unsigned-murmurice branch from 5af3f5b to 8728ea7 Mar 18, 2017

@mkrautz mkrautz merged commit 3313f9b into mumble-voip:master Mar 18, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.