Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overlay: treat launchers as implicitly blacklisted programs. #2985

Merged
merged 1 commit into from Apr 1, 2017

Conversation

@mkrautz
Copy link
Member

commented Mar 28, 2017

This is useful for cases like GTA V.

Its launcher is available via Steam, or via Rockstar Social Club/Retail.

Before this change (if it wasn't already in the blacklist), the GTA V
Launcer, when launched through Steam, would show the overlay.
Now, since we treat it as a launcher, it'll be implicitly blacklisted.

@mkrautz mkrautz requested review from Kissaki, hacst and davidebeatrici Mar 28, 2017

@davidebeatrici

This comment has been minimized.

Copy link
Member

commented Mar 29, 2017

Typo in the PR message: Launcer, when launched through Steam, would show the overlay.

@mkrautz

This comment has been minimized.

Copy link
Member Author

commented Mar 29, 2017

Typo in the PR message: Launcer, when launched through Steam, would show the overlay.

And commit message...

overlay: treat launchers as implicitly blacklisted programs.
This is useful for cases like GTA V.

Its launcher is available via Steam, or via Rockstar Social Club/Retail.

Before this change (if it wasn't already in the blacklist), the GTA V
Launcher, when launched through Steam, would show the overlay.
Now, since we treat it as a launcher, it'll be implicitly blacklisted.

@mkrautz mkrautz force-pushed the mkrautz:blacklist-launchers branch from 9038712 to a9bdde0 Mar 30, 2017

@mkrautz mkrautz merged commit 15d18ee into mumble-voip:master Apr 1, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.