Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discard duplicate path exceptions #3000

Merged
merged 1 commit into from Apr 6, 2017

Conversation

@Kissaki
Copy link
Member

commented Apr 6, 2017

The three file lists already discard duplicate entries. Do the same for
paths in the path exceptions list.

Discard duplicate path exceptions
The three file lists already discard duplicate entries. Do the same for
paths in the path exceptions list.

@Kissaki Kissaki added the overlay label Apr 6, 2017

@Kissaki Kissaki requested a review from mkrautz Apr 6, 2017

@mkrautz
mkrautz approved these changes Apr 6, 2017
Copy link
Member

left a comment

LGTM if it passes the reviews.

Do we need similar logic for the other lists?

@Kissaki

This comment has been minimized.

Copy link
Member Author

commented Apr 6, 2017

What other lists? For these four, as I wrote, the other three (file lists) already discard duplicates.

The path list was inconsistent. But with this change also discards duplicates.

@mkrautz

This comment has been minimized.

Copy link
Member

commented Apr 6, 2017

SGTM, I shouldn't be reviewing at this hour. :-)

@Kissaki Kissaki merged commit c1e9102 into mumble-voip:master Apr 6, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Kissaki Kissaki deleted the Kissaki:olay-exceptions-no-dupl-paths branch Apr 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.