Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Accept File And Folder Drops In Overlay Exceptions #3001
As described in the second commit, there's an open issue:
The dialogs are modal
I could make all four list widgets not accept drops before opening the dialog, and then making them accept them afterwards again, but that seems tedious; a lot of logic to fix unexpected (to me) behaviour. @mkrautz any input/ideas regarding this?
mkrautz left a comment
Can you refactor this to:
? It would make it seem much simpler.
Code looks good otherwise.
Maybe setting the window parent does?
It seems my test did not effectively use my code changes/assumptions. After setting up a small test project I was able to verify the non-native dialog works (correctly catches drops). I then verified in fact the Qt Creator file open dialog also does not correctly catch drop events.
I would like to test now, but my Overlay currently does not show anywhere anymore - even on current Snapshot.
Can add multiple paths and files by dropping them. Adds only adequate entries.
I did not change the use of the native dialog, even with the issue. The issue exists in Qt Creator as well, and probably every other place we use the QFileDialog. I'd rather keep this for now, instead of making the file dialog inconsistent with (potential) other places we use one (by using the Qt dialog, which looks/is a bit different).
They were added in lowercase first (by Qt Creator), but I changed them to match our CamelCase naming. The generated include statement is lowercase on Windows as well.
I adjusted the file name in the "promote" dialog in Qt Creator (SO), which resulted in a